search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Enable classic editor #6

Closed engineering-this closed 4 years ago

engineering-this commented 5 years ago

CKEditor component is forcing divarea plugin. We should should enable use of the classic editor.

Currently we are unable to fix this issue. Usage of framed editor in Angular can cause some memory leaks, and console errors. Angular doesn't allow cleanup before elements are removed from DOM, ngOnDestroy is called when elements are already removed.

There is a feature request on Angular GH: https://github.com/angular/angular/issues/17404 Once it is resolved we can allow the usage of classic editor.

f1ames commented 5 years ago

This issue will be fixed by upstream issue - https://github.com/ckeditor/ckeditor-dev/pull/3128 and then we can enable classic editor in the integration.

engineering-this commented 5 years ago

I wonder if we should keep divarea as default editor type, so no breaking changes are introduced? Or change it to classic?

If we accept breaking changes during beta phase, we can consider going further, and allow type=inline and type=classic only. This would allow us to get rid of logic to ensure divarea plugin included in config. In that case if you want to have divarea, just add that plugin to your config.

wwalc commented 5 years ago

Since we had a beta release so far, there is no need for keeping backwards compatibility. It should be enough to explain any changes in the changelog and the blog post.