search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Update deps #61

Closed Dumluregn closed 4 years ago

Dumluregn commented 4 years ago

Updated deps and devdeps according to https://david-dm.org/ckeditor/ckeditor4-angular and https://david-dm.org/ckeditor/ckeditor4-angular?type=dev. TypeScript was only updated to version 3.5.3 as this is what Angular 8 allows (Angular 9 will require TS 3.6).

There were some issues to fix, primarily in unit tests, but they work fine now - the biggest change was rewriting test should create editor with CKEDITOR.${method} as if I understand this comment correctly it couldn't work the old way anymore.

e2e tests are currently broken as reported in #60.

Closes #32. Closes #52.

Dumluregn commented 4 years ago

The reason for failing test for IE11 were missing polyfills. I didn't bother to add them before as they were unnecessary for CKEditor, but turned out to be relevant here - we need polyfills for both tests using console and when ensuring that divarea plugin is loaded. Deleting them earlier was pretty reckless, sorry 😞

I wanted to mention one more thing. I see that updating ng-packgr in CKEditor5-angular resulted in breaking production builds. I tried to reproduce this error in our repo and it seems to work fine, but still please check it too before merging.

f1ames commented 4 years ago

Rebased onto latest master.