search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Element Ref is not generic error is thrown in Angular 5 on build #66

Closed Chinna2405 closed 4 years ago

Chinna2405 commented 4 years ago

Are you reporting a feature request or a bug?

Provide detailed reproduction steps (if any)

1.On running the ng build command i am getting the below error. 2.ERROR in node_modules/ckeditor4-angular/ckeditor.component.d.ts(113,29): error TS2315: Type 'ElementRef' is not generic.

Expected result

What is the expected result of the above steps?

Actual result

What is the actual result of the above steps?

Other details

Thanks in Advance.

f1ames commented 4 years ago

Hello @Chinna2405, this issue was already addressed in #40 PR. The package with the fix will be released next week.

paolomainardi commented 4 years ago

I am having the same issue, is there any workaround before the new release ?

f1ames commented 4 years ago

The change needed is quite simple - https://github.com/ckeditor/ckeditor4-angular/pull/40/files#diff-756e5674b9c69ad85fad09a2b0c3e852R194 so you may try apply it manually.

The best bet would be building package from the current master like:

git clone https://github.com/ckeditor/ckeditor4-angular.git
cd ckeditor4-angular
npm run build-package