search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

IE11 unstable "DemoForm Component should create" unit test #74

Open f1ames opened 4 years ago

f1ames commented 4 years ago

Are you reporting a feature request or a bug?

Failing test

Provide detailed reproduction steps (if any)

Unstable DemoForm Component should create test which sometimes fails on IE11/Edge. I have added longer Jasmine timeouts but looking at the log, two timeouts are mentioned in the error (default and the longer one) so I'm not sure if it works correctly and should be investigated:

image

f1ames commented 4 years ago

Same as in https://github.com/ckeditor/ckeditor4-angular/issues/73#issuecomment-658799263 - working with unstable tests is usually difficult, since it's hard to determine sometimes if they are fixed already or not (due to its instability). The recent master has all unit tests green on CI (see https://travis-ci.org/github/ckeditor/ckeditor4-angular/builds/708351469#L257)

and if this instability is not easily reproducible locally we should just observe how it works for couple of CI tests runs and then act if it fails again.

Also have in mind that Edge is now Chromium so it concerns IE11 only (I have updated issue title).

f1ames commented 4 years ago

Let's check quickly if something can be done and if not ignore failing test on IE11.