search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Bump dependencies #98

Closed Dumluregn closed 4 years ago

Dumluregn commented 4 years ago

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

dependencies devDependencies

The second one is not as important as the main deps.

ezintz commented 4 years ago

Hello, I have been doing this in my fork. Everything is still working, but my changes for additional common events are included. I will wait until that one is merged to open another pull request.

Would it make sense to have different releases for different Angular versions? I was thinking about to go with Angular versions e.g. 9.x.x or 8.x.x for previous version.

f1ames commented 4 years ago

Hello @ezintz,

dependencies of ckeditor4-angular package are rather minimal - only load-script and tslib (see on NPM) so I'm not sure if there is any sense in having different releases for different Angular versions. Do yo think there could be any issue with newer/older Angular versions with those deps?

f1ames commented 4 years ago

As for devDependencies we have an issue with @angular-devkit/build-angular dependency which requires node-sass@4.10.0 and so we cannot build docs (ckeditor4-docs) with never than 10 version of node (because it is used there too).