search

ckeditor / ckeditor4-presets

CKEditor 4 presets builder.
18 stars 27 forks source link

Include editorplaceholder plugin into preset #35

Closed jacekbogdanski closed 4 years ago

jacekbogdanski commented 4 years ago

I suppose it should go into full preset only, but cc @f1ames

Placeholder text plugin issue: https://github.com/ckeditor/ckeditor4/issues/3793

f1ames commented 4 years ago

That's a good question, what is the default config for placeholder plugin? I mean what will be the effect or adding it to presets without adjusting any configuration? Will it start to display default placeholder or placeholder text needs to be set explicitly? I wonder how it will affect existing integrations :thinking:

jacekbogdanski commented 4 years ago

It won't be visible without explicitly set placeholdertext config option.

f1ames commented 4 years ago

It won't be visible without explicitly set placeholdertext config option.

So if by default it doesn't change anything we could include it in full and standard presets. OTOH we have standard-all which have this purpose of being standard but with all plugins easily available. Let's stick with full preset only then, WDYT?

jacekbogdanski commented 4 years ago

Sounds good :+1:

jacekbogdanski commented 4 years ago

Closed in #38