search

ckeditor / ckeditor4-presets

CKEditor 4 presets builder.
18 stars 27 forks source link

Add uploadfile plugin to full and standard presets. #44

Closed hub33k closed 4 years ago

hub33k commented 4 years ago

Close  #16

f1ames commented 4 years ago

It seems adding the plugin affects unit tests results (about 23 test failing on CI). This will require analyzing each test to see what's going on and why, so probably could take some time :thinking: Not sure if it's worth pushing forward especially that #16 issue is 2.5 years old and nobody upvoted it or added any comments there.

The assumption was it will be straightforward thing to do so we can do it quick, but if it grows significantly it's probably not worth it.

f1ames commented 4 years ago

OTOH is plugin is really simple so shouldn't have many side effects. OTOH2 adding it by default which means that all standard and full instances, from now, will throw uploadfile-config error - which is rather not an elegant think (we already discussed it when enabling exportpdf by default in full preset).

For me the fact that adding this plugin by default means also adding an error by default is rather a no go so I'm for ditching this idea.

f1ames commented 4 years ago

@hub33k good that we were able to check it, but due to https://github.com/ckeditor/ckeditor4-presets/pull/44#issuecomment-702654228 and https://github.com/ckeditor/ckeditor4-presets/pull/44#issuecomment-702656045 let's just leave presets default plugins as is.