search

ckeditor / ckeditor4-presets

CKEditor 4 presets builder.
18 stars 27 forks source link

Remove the WSC plugin from standard and full presets #53

Closed wwalc closed 3 years ago

wwalc commented 3 years ago

Following ckeditor/ckeditor4#4423 in the nearest major release of CKEditor 4 we should do the following:

(remember about our demo preset too)

f1ames commented 3 years ago

Moved from ckeditor4 to ckeditor4-presets.

f1ames commented 3 years ago
  • Remove WSC from the default setup in CKEditor 4 presets.

@wwalc So we don't want to leave it as is (active by default) and ask WSC team to add EOS/EOL message to the plugin itself so users/customers can decide when and how to migrate? Removing it will have bigger impact (and surprise element probably), while adding message will make people aware that it's going to change (and probably we can remove it some time after that).

  • The WSC plugin should be still available in the plugins folder as opt-in solution until Q3/Q4 2021 in std-all / full-all distributions.

@wwalc so based on that and previous point it means WSC plugin should be available in the presets (so in prestes plugins/ directory) but not active by default?

  • Update the documentation stating that the WSC plugin is no longer a part of CKEditor 4 presets, but can be added via the online builder and/or through extraPlugins in case of a CDN.

Done in ckeditor/ckeditor4#4423.

(remember about our demo preset too)

Extracted to #54.

f1ames commented 3 years ago

I suppose more clarification on in which direction we would like to move could be useful. The WSC plugin is available and active by default in standard, standard-all, full and full-all presets.

There were two ideas here:

  1. Leave it as is (WSC available and active by default in all 4 presets) and add an information to WSC dialog itself about EOS/EOL.
  2. Deactivate the WSC plugin in all 4 presets (that's my assumption since https://github.com/ckeditor/ckeditor4-presets/issues/53#issue-766202242 mentions only *-all presets :thinking:), but still make it available in the build folder.

:point_up: cc @wwalc 

If we go with the 2nd approach we should first check if deactivating WSC in any preset can break existing integrations. The scenario is simply updating CKEditor 4 to next version (without WSC) and see if any configuration used related to WSC will break something (or if there is an API which will stop to be available). If it's ok, that's acceptable approach, but if it causes any issues (so basically breaking changes) we should reconsider other approaches.

@wwalc could you clarify on:

  • The WSC plugin should be still available in the plugins folder as opt-in solution until Q3/Q4 2021 in std-all / full-all distributions.

Do you mean *-all presets only or all 4 presets mentioned above? Because unless we remove WSC entirely it still will be available in all *-all presets (the same way as all official plugins).

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this issue as stale due to inactivity. Please provide the requested feedback or the issue will be closed after next 7 days.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this issue as stale due to inactivity. Please provide the requested feedback or the issue will be closed after next 7 days.

CKEditorBot commented 3 years ago

Closed in https://github.com/ckeditor/ckeditor4-presets/pull/55