search

ckeditor / ckeditor4-react

Official CKEditor 4 React component.
Other
95 stars 51 forks source link

Ensure that package works correctly with React 18 #284

Closed MMMalik closed 1 year ago

MMMalik commented 2 years ago

Are you reporting a feature request or a bug?

Other

Provide detailed reproduction steps (if any)

A new major version of React that has been recently released.

https://reactjs.org/blog/2022/03/29/react-v18.html https://github.com/facebook/react/releases/tag/v18.0.0

Ensure that ckeditor4-react works fine with React 18. Adjust testing scenarios so that they include React 18 as well.

MMMalik commented 2 years ago

I've created locally a new sample with React 18 and ckeditor4-react package appears to be working correctly.

However, it looks like testing tool we rely on, react-hooks-testing-library, is not yet ready for React 18. That package will be soon integrated with react-hooks-testing-library but until that happens we have a blocker.

Also, latest version of react-testing-library drops support for React < 18, so we will need to adjust our testing scripts to be able to test v16, v17, and v18.

My suggestion is to revisit this task once react-hooks-testing-library introduces support for hooks. In the meantime, ckeditor4-react package appears to be working fine with React 18. Only issues users might run into are related to dependencies installation due to missing ... || ^18 in peerDependencies.

mingxin-yang commented 2 years ago

Hello, I am also facing this problem, how can I introduce it into the react 18 project first, I am a react novice, and now the introduction will report an error. @MMMalik

MMMalik commented 2 years ago

Hi @mingxin-yang,

React component and hook exposed by ckeditor4-react should work just fine with React 18. However, you might encounter issues with installation if you rely on package manager that strictly resolves peer dependencies, such as npm@7 (or higher). In such case installation with --legacy-peer-deps (or equivalent) should help.

Our long-term plan is to release a new major version of ckeditor4-react which will fully support React 18. This should happen within several weeks from now.

mingxin-yang commented 2 years ago

Cool! Thank you. @MMMalik

CKEditorBot commented 1 year ago

Closed in https://github.com/ckeditor/ckeditor4-react/pull/288