ckeditor / ckeditor4-react

Official CKEditor 4 React component.
Other
97 stars 52 forks source link

Enable official support for React 18 #288

Closed MMMalik closed 2 years ago

MMMalik commented 2 years ago

This PR officially enables support for React 18. The following work has been done:

Closes #284.

MMMalik commented 2 years ago

This is ready for review.

One more considration to be taken into account: React 18 drops support for IE11 :see_no_evil:. So if we enable support for React 18 exclusively, then we also basically drop support for IE11 in React integration.


There are still alternative routes we can take. For instance, we can enable support for React from 16.8.x to 18.x AND loosen our testing policies:

This way we could cover with tests all versions our source code would work on and unlock official support for React 16.8 to 18.x via peerDependencies:

"peerDependencies": {
    "ckeditor4": "^4.19.0",
    "react": "^16.8 || ^17 || ^18"
},
MMMalik commented 2 years ago

This is ready for another round of review.

Few changes were introduced:

MMMalik commented 2 years ago