search

ckeditor / ckeditor4-releases

Official distribution releases of CKEditor 4.
Other
521 stars 412 forks source link

CE-624: CKEditor link tool allows invalid URLs #81

Closed RyanCopley closed 6 years ago

engineering-this commented 6 years ago

Hello,

First of all, we don't commit changes directly to release repository. Please move your commit to ckeditor-dev which is our working repository.

For any Pull Request please don't commit any changes or files that are irrelevant to feature/fix you want to bring to CKEditor. Files like .dockerignore, .gitignore, .npmrc, dockerfile, package.json shouldn't be commited. Also any extra plugins that you are using in your build shouldn't be commited.

Last but not least. Every feature or bug fix should be covered with tests, both manual and unit tests. Please include them in your PR.

Further reading on contributing to CKEditor: https://docs.ckeditor.com/ckeditor4/latest/guide/dev_contributing.html https://docs.ckeditor.com/ckeditor4/latest/guide/dev_contributing_code.html

If anything is unclear feel free to ask questions, we are happy to have community contributions to our software.

mlewand commented 6 years ago

@RyanCopley also as a general rule, based on your gif, I suggest that you should put a textual information on what went wrong. The fact that it's obvious to you that the URL is wrong, doesn't mean that other (less tech-saavy) users know that. 🙂

RyanCopley commented 6 years ago

Sorry, this was meant to be PR'd against our private repository.