search

ckeditor / ckeditor4-sdk

A set of software development tools for CKEditor 4 along with samples.
Other
18 stars 21 forks source link

Make samples browsable in dev mode #160

Closed Tade0 closed 9 years ago

Tade0 commented 9 years ago

159.

After some wrestling with the system I established, that given how many operations are done on the sample files during building it's best not to replicate this behavior in the dev environment so I settled on only modifying the paths of the CSS file and CKEditor script.

At this point the main difference between the dev and built samples is a lack of navigation in the former.

Reinmar commented 9 years ago

Can't the fixExternalPaths() work on string instead of DOM? This replacement should be plain simple.

Reinmar commented 9 years ago

When opening a code sample:

GET http://localhost/ckeditor-sdk/dev/ckeditor_sdk/template/theme/img/close.png 404 (Not Found)
Tade0 commented 9 years ago

Well, in the comment I voiced my opinion on not using abstractions when they're available. :)

To fix the problem with the close button I need to transform simplesample.js, so I think instead of trying to fix it now it would be better to either: -Wait for #151 to get merged and rebase. -Solve this problem in #151.

Reinmar commented 9 years ago

So let's wait until #151 is resolved.

Reinmar commented 9 years ago

OK, #151 is merged. You can continue with this ticket.

Tade0 commented 9 years ago

404 fixed.