search

ckeditor / ckeditor4-vue

Official CKEditor 4 Vue component
Other
77 stars 17 forks source link

Use `delayIfDetached` config for editor set to `true` by default #102

Closed sculpt0r closed 2 years ago

sculpt0r commented 3 years ago

Are you reporting a feature request or a bug?

Feature

Base on our investigation on https://github.com/ckeditor/ckeditor4/issues/4390 issue and fix we provide for it: https://github.com/ckeditor/ckeditor4/pull/4463. We should use the delayIfDetached config set to true by default in integrations, just to prevent any issue. Also, we need to adjust editor creation: to properly maintain editor data. https://github.com/ckeditor/ckeditor4-vue/blob/69744fb8385413998d35fe4a53e52e8d89a05cb8/src/ckeditor.js#L67 The above line assumes we get editor instance, but that doesn't have to be true with delayed creation.

Expected result

What is the expected result of the above steps?

Actual result

What is the actual result of the above steps?

Other details

sculpt0r commented 3 years ago

Blocked until 4.17.0 release.

sculpt0r commented 2 years ago

Since: https://github.com/ckeditor/ckeditor4/releases/tag/4.17.0 - no longer blocked

CKEditorBot commented 2 years ago

Closed in https://github.com/ckeditor/ckeditor4-vue/pull/128