ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.79k stars 2.48k forks source link

A11y Instructions dialog for MAC should mention Cmd+L as well as Control+L shortcuts #2200

Open jswiderski opened 6 years ago

jswiderski commented 6 years ago

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open Safai on Mac, focus editor and press Alt+0 to open A11y dialog.
  2. You can see that dialog say Cmd+L is the shortcut for link.
  3. Focus dditor and press Cmd+L

Expected result

Link dialog gets opend.

Actual result

What works on Chrome or Firefox, doesn't on Safari as Safari by default uses this shortcut to Open Location (enter different URL): screen shot 2018-07-03 at 11 19 53

Other details

The Control+L shortcut works fine in all browsers while Cmd+L works on Firefox, Chrome but not Safari. Taking that into account, the A11y dialog should mention both shortcuts for MAC

jacekbogdanski commented 1 year ago

Line responsible for detecting os functional key: https://github.com/ckeditor/ckeditor4/blob/4ec334ebc8ed38a935406b87044c1c1b0788eaa4/plugins/a11yhelp/dialogs/a11yhelp.js#L82