search

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.8k stars 2.48k forks source link

Unstable PFW test related to filters loading #3424

Open f1ames opened 5 years ago

f1ames commented 5 years ago

Type of report

Failing tests

Provide detailed reproduction steps (if any)

Some PFW tests fails randomly, for example see ~https://travis-ci.org/ckeditor/ckeditor4/jobs/585973103~ https://github.com/ckeditor/ckeditor4/issues/3424#issuecomment-937711373. It looks like there might be some inconsistency / race condition when loading PFW filters and so sometimes the filters are not ready when test are executed.

f1ames commented 5 years ago

I think this is the same issue which was mentioned during #835 review (see https://github.com/ckeditor/ckeditor4/pull/3257#pullrequestreview-280849505) regarding the same tests failing on Edge:

image

f1ames commented 4 years ago

Fixed in #3539.

f1ames commented 4 years ago

Reopening since it it still an issue as we seen during recent testing phase.

Comandeer commented 3 years ago

They seem to fail on the first test run and only in Firefox. After that, they run smoothly. Unfortunately there is only the first run on CI, so it fails there more regularly, e.g. https://app.travis-ci.com/github/ckeditor/ckeditor4/jobs/541909640 or https://app.travis-ci.com/github/ckeditor/ckeditor4/jobs/541657054.

Comandeer commented 3 years ago

It seems that Firefox does something weird during script loading and load event does not mean that script is loaded and executed. Now I'm experimenting with using afterscriptexecute event in the script loader and the initial results are promising.

Comandeer commented 2 years ago

It seems that the issue can be reproduced in Chrome after all. So probably the issue is deeper and connected with our script loader.

sculpt0r commented 2 years ago

That should be fixed as a part of a bigger solution, e.g. #4948

I was able to reproduce the issue (this time on Brave - chrome) only thanks to the browser plugin, which automatically refreshes the tab and stops if certain text is on the page...

All scripts are loaded, the only 404 is for favicon. Some screens, might eventually help: Screenshot 2022-03-30 at 22 39 36 Screenshot 2022-03-30 at 22 40 55 Screenshot 2022-03-30 at 22 40 40