ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.79k stars 2.47k forks source link

Find a way to destroy editor when iframe is loaded on Safari #3426

Closed msamsel closed 2 years ago

msamsel commented 5 years ago

Type of report

Task

Provide a description of the task

Currently, there are ignored tests on safari which destroys editor after iframe load. What is strange, that tests are passing when debugging console is turned on. There might be some sort of optimization in Safari which loads this iframe more secure or somehow independently, what results in failing test. It could be nice to find another way, which would allow on destroying the editor in that specific moment.

https://github.com/ckeditor/ckeditor4/blob/major/tests/core/editor/detaching.js (link will be working after merge of #3128)

I tried to overwrite the original prototype method in CKEDITOR.editor.prototype.addMode, however, it doesn't work for me.

image

jacekbogdanski commented 2 years ago

Dup of https://github.com/ckeditor/ckeditor4/issues/5191