Some of "plugins/forms" unit tests fails on IE8

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.

https://ckeditor.com/ckeditor-4

Other

5.79k stars 2.47k forks source link

Some of "plugins/forms" unit tests fails on IE8 #3700

Closed f1ames closed 3 years ago

f1ames commented 4 years ago

Type of report

Failing tests

Provide description of the task

The error is 'type' is null or not an object, the same as in #3527 so it might be related (the cause might be the same).

Other details

Browser: IE8
OS: Windows 7
CKEditor version: 4.13
Installed CKEditor plugins: -

Comandeer commented 4 years ago

Seems like https://github.com/ckeditor/ckeditor4/commit/4b25e68d2d1ee737a3b8ae4c26044504de25fbc3 is guilty.

f1ames commented 4 years ago

Probably the same fix could be applied to #3257 as it seems like the same issue.

f1ames commented 4 years ago

Also tests/plugins/placeholder/dialog fails with the same error (and same cause most probably).

sculpt0r commented 3 years ago

I've rerun this one a few times and everything is fine. Looking at the numbers and those tests code - they are already ignored. So, currently, we can close this issue.