search

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.79k stars 2.48k forks source link

Failing /tests/plugins/placeholder/dialog tests in IE8 #3768

Closed f1ames closed 3 years ago

f1ames commented 4 years ago

Type of report

Failing tests

Provide description of the task

All unit tests from /tests/plugins/placeholder/dialog suite fail on IE8.

Other details

sculpt0r commented 3 years ago

It is already ignored: https://github.com/ckeditor/ckeditor4/blob/37e82adb1e306c3c9d77fb1a6e64e623c71d0c81/tests/plugins/placeholder/dialog.js#L9-L11

It is nicely ignored when run as a group of tests, but as a single test - it is ignored but the errors pop out - because of lack of return.

CKEditorBot commented 3 years ago

Closed in https://github.com/ckeditor/ckeditor4/pull/4860