Open iamsjy17 opened 4 years ago
It seems we are indeed handling this improperly. input
event in called but doesn't lead to firing change
event, and it causes further failures, e.g. if you add emoji in described way and delete it, then editor creates inexecutable undo step:
Type of report
Bug
Provide detailed reproduction steps (if any)
In the example source above, when i input an emoji through the Mac os system input. the
change
event is not fired.Expected result
In general, when input through keyup, the change event fire.
Actual result
Since entering an emoji also changes the data, the change event should occur generally, but it isn't.
https://github.com/ckeditor/ckeditor4/blob/d1710c198d8f5007e8d04fed9870bfd4b182ae54/plugins/undo/plugin.js#L1048
Looking at the ckeditor4 code, a change event is fired through the keyup method.
https://github.com/ckeditor/ckeditor4/blob/d1710c198d8f5007e8d04fed9870bfd4b182ae54/plugins/undo/plugin.js#L1001
However, the change event isn't fired through the input method.