ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.8k stars 2.48k forks source link

Color button should handle ACF when custom `colorButton_foreStyle` config used #3996

Open hub33k opened 4 years ago

hub33k commented 4 years ago

Type of report

Feature request

Provide description of the new feature

When we change color button settings to use classes instead of style attribute (via `colorButton_foreStyle` config), ACF removes class property when switching to source view and back. This can be easily solved by additional extraAllowedContent: 'span(*)' config. However, it will be more convenient if color button plugin could automatically detect such config and adjust ACF settings.

Example: https://codepen.io/f1ames/pen/JjYXZgp

Mght be related to #3994.

f1ames commented 4 years ago

See https://github.com/ckeditor/ckeditor4/issues/3994#issuecomment-624033028.