Cache key not applied everywhere

TZanke commented 3 years ago

Type of report

Bug

Every file should have a ?t=123 cache key.

tableselection.css?t=123

At least some, like tableselection.css do not have a cache key.

tableselection.css

Browser: Chrome 90
OS: Suse 15.2
CKEditor version: "4.16.1 (Standard)"
Installed CKEditor plugins: "dialogui,dialog,a11yhelp,about,notification,button,toolbar,clipboard,textmatch,fakeobjects,link,autolink,undo,autoembed,basicstyles,blockquote,panelbutton,panel,floatpanel,colorbutton,colordialog,menu,contextmenu,copyformatting,elementspath,lineutils,widgetselection,widget,notificationaggregator,embedbase,embedsemantic,enterkey,entities,popup,filetools,filebrowser,floatingspace,listblock,richcombo,font,format,horizontalrule,htmlwriter,image,image2,indent,indentblock,indentlist,justify,list,liststyle,magicline,maximize,pastefromword,pastetext,preview,print,removeformat,resize,menubutton,scayt,showborders,sourcearea,sourcedialog,specialchar,stylescombo,tab,table,tabletools,tableresize,tableselection,uploadwidget,uploadfile,uploadimage,wysiwygarea"

sculpt0r commented 3 years ago

Hi @TZanke Thank you for the report. I can confirm this issue.

So we have here:

BUG: not all editor assets are requested by the browser with timestamp, e.g. CSS assets added by plugins
TO VERIFY: does timestamp generator takes into account our config - so the User can add external resources e.g. CSS assets and change the timestamp without rebuilding the entire editor

CKEditorBot commented 3 years ago

jacekbogdanski commented 2 years ago

Unfortunately, we had to roll back this fix as it started to break relative CSS links. We will work on it for the next release.

CKEditorBot commented 2 years ago