search

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.79k stars 2.47k forks source link

Failing test: tests/plugins/pagebreak/pagebreak [SAFARI] #4816

Closed sculpt0r closed 3 years ago

sculpt0r commented 3 years ago

Type of report

Bug

Provide detailed reproduction steps (if any)

Failing test: test paste

Full test path: tests/plugins/pagebreak/pagebreak#tests%2Fplugins%2Fpagebreak%2Fpagebreak%20test%20paste

Expected result

What is the expected result of the above steps?

Test passed.

Actual result

What is the actual result of the above steps?

Test failed.

Error
TypeError: undefined is not an object (evaluating 'range.checkReadOnly')
tests/plugins/pagebreak/pagebreak test paste

Unexpected error: undefined is not an object (evaluating 'range.checkReadOnly')
Expected: undefined (undefined)
Actual:   undefined (undefined)

Other details

sculpt0r commented 3 years ago

It is not failing on Safari 13.1 🤔 Also, not failing on Chrome, FF.

Failing even back to 4.14.0 so it looks like safari problem here.

f1ames commented 3 years ago

DUP of https://github.com/ckeditor/ckeditor4/issues/4759.

f1ames commented 3 years ago

In fact https://github.com/ckeditor/ckeditor4/issues/4759 lists more than one failing test with not that much information so let's leave this open and close #4759.

We had already concluded that this is new Safari upstream not caused by changes in CKEditor 4 itself.

f1ames commented 3 years ago

It would be good to check if it's only the test which is failing or something is broken in the pagebreak plugin itself. cc @sculpt0r

sculpt0r commented 3 years ago

Duplicate: https://github.com/ckeditor/ckeditor4/issues/4690