search

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.8k stars 2.48k forks source link

Element is blockLimit and block at the same time #4897

Open ScalableJS opened 3 years ago

ScalableJS commented 3 years ago

Element DIV with attributes contenteditable has two status blockLimit and block at the same time https://github.com/ckeditor/ckeditor4/blob/f2193e82559032d133b84d3621a2cef4440a9dbd/core/dom/elementpath.js#L85 Maybe after the line should be break because the element will be split after the line https://github.com/ckeditor/ckeditor4/blob/f2193e82559032d133b84d3621a2cef4440a9dbd/core/dom/elementpath.js#L94

KarolDawidziuk commented 3 years ago

Hi @ScalableJS

Could you provide more information with real use cases using one of our templates?

CodePen: https://codepen.io/Comandeer/pen/ExaMgpz?editors=1010 JSFiddle: https://jsfiddle.net/Comandeer/d6ey8a2w JSBin: https://jsbin.com/keqekef/1/edit?html,js,output StackBlitz: https://stackblitz.com/edit/js-vcqfw3

Additionally, I encourage you to use one of our templates for feature requests and bug reports. Their purpose is to make sure you provide the most sufficient and clear description.

ScalableJS commented 3 years ago

@KarolDawidziuk Example: https://codepen.io/oleg056/pen/LYLrweX

Steps reproduce: 1) Apply bulleted list into Area 1 2) Apply bulleted list into Area 2

In the example you can see Area 1 will be splitted despite the element is "blockLimit". But the Area 2 will not be splitted. It happens because DIV with contenteditable and the same time have status "block" and "blockLimit" (the logic placed in "elementPath")