ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.78k stars 2.46k forks source link

Fix failing tests in Chrome #5432

Closed Comandeer closed 1 year ago

Comandeer commented 1 year ago

What is the purpose of this pull request?

Failing tests fix

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more on PR testing, how to set the testing environment and how to create tests in the official CKEditor documentation.

This PR contains

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

What is the proposed changelog entry for this pull request?

N/A

What changes did you make?

I've forced selection in bot#setData() method when it's called with an empty string and the editor is iframe-based one. Additionally, I've forced selections in some widget tests.

Which issues does your PR resolve?

Closes #5385.