search

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.78k stars 2.46k forks source link

Support custom type attribute in scriptLoader method with new parameter T/5434 #5435

Closed matthandus closed 1 year ago

matthandus commented 1 year ago

What is the purpose of this pull request?

New feature to support a custom type attribute on the rendered script tag from the method CKEDITOR.scriptLoader.load to better integrate with applications that may need this, like Drupal.

<script src="/path/to/script.js" type="module"></script>

Does your PR contain necessary tests?

New test named 'test load with custom type attribute' in /tests/core/scriptloader.js.

This PR contains

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

What is the proposed changelog entry for this pull request?

* [#5434](https://github.com/ckeditor/ckeditor4/issues/5434): Support custom type attribute in scriptLoader method with new parameter.

What changes did you make?

Added a new parameter named 'typeAttribute' to the load method on CKEDITOR.scriptLoader that is default to 'text/javascript'. This will allow Drupal developers to set the custom type attribute of 'module' on the script tag when needed. Also added a new test to confirm the custom parameter works.

Which issues does your PR resolve?

Closes #5434.

github-actions[bot] commented 1 year ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

matthandus commented 1 year ago

Hello, just reviewing the feedback now. I will respond soon. Thank you!

github-actions[bot] commented 1 year ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

github-actions[bot] commented 1 year ago

There was no activity regarding this pull request in the last 14 days. We're closing it for now. Still, feel free to provide us with requested feedback so that we can reopen it.