Closed KarolDawidziuk closed 1 year ago
Thanks, @Comandeer for your input. I've applied changes mentioned in your comments and PR is ready for another review.
It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.
What is the purpose of this pull request?
Task
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more on PR testing, how to set the testing environment and how to create tests in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
In the previous PR with fixing print on Firefox, we allowed using document.domain to properly open the preview before print while using the editor from CDN. Looks like FF fixed this and we can remove it. Additionally, we could simplify the code more by removing fix for creating links to anchor.
Which issues does your PR resolve?
Closes #5412.