search

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.78k stars 2.46k forks source link

Remove italic style from TextPartLanguage feature. #5455

Closed vladsolntsev closed 1 year ago

vladsolntsev commented 1 year ago

Type of report

Task

Provide description of the task

Remove the default CSS styling of the span[lang]

Other details

This was just implemented in Ckeditor5 here - https://github.com/ckeditor/ckeditor5/pull/13804.

I think that this makes sense, as setting the italic font-style on the selected language is not intuitive at all, and makes it difficult for editors to know what part of the text is really in italic and what part is just a translated language.

github-actions[bot] commented 1 year ago

It's been a while since we last heard from you. We are marking this issue as stale due to inactivity. Please provide the requested feedback or the issue will be closed after next 7 days.

KarolDawidziuk commented 1 year ago

Hi @vladsolntsev and sorry for the late reply.

As the CKEditor 4 allows you to modify styles placed inside the contents.css file in several different ways, there is no need to remove this. To change it you can use one of the configuration options:

I'm closing this report.