fix(language): remove default italic style for language selection - Githubissues

ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.

https://ckeditor.com/ckeditor-4

Other

5.78k stars 2.46k forks source link

fix(language): remove default italic style for language selection #5456

Closed vladsolntsev closed 1 year ago

vladsolntsev commented 1 year ago

What is the purpose of this pull request?

To remove the default italic style for selected language text.

This was just approved for Ckeditor5 here (https://github.com/ckeditor/ckeditor5/pull/13804).

Does your PR contain necessary tests?

Only CSS is changed.

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

[x] PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

https://github.com/ckeditor/ckeditor4/issues/5455: Text with language set is no longer styled as italic. To re-enable previous behavior, add style .ck-content span[lang] { font-style: italic; } to your css.

What changes did you make?

Remove the italic styling on span[lang] attribute.

Which issues does your PR resolve?

Closes #5455

KarolDawidziuk commented 1 year ago

Hi @vladsolntsev and thank you for the PR.

I'm closing this PR because there is no need to remove this. You can use one of the available editor configuration options for that. For more information please see: https://github.com/ckeditor/ckeditor4/issues/5455#issuecomment-1510869180.