ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.79k stars 2.48k forks source link

MathJax Plugin: Propose MathJax 3 support #5475

Closed Enquier closed 1 year ago

Enquier commented 1 year ago

What is the purpose of this pull request?

Allow users to select Mathjax v3 as the version for the math

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more on PR testing, how to set the testing environment and how to create tests in the official CKEditor documentation.

This PR contains

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

What is the proposed changelog entry for this pull request?

* [#3411](https://github.com/ckeditor/ckeditor4/issues/3411): A config option was added for the mathjax plugin to allow the user to select and use MathJax v3. The necessary code was added to the widget to enable use of v3.

What changes did you make?

-Added code to the widget that will execute correctly using V3, added config option to specify

Which issues does your PR resolve?

Closes #3411.

Enquier commented 1 year ago

@Comandeer I updated based on your feedback. Let me know if there are any other concerns you have

github-actions[bot] commented 1 year ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

github-actions[bot] commented 1 year ago

There was no activity regarding this pull request in the last 14 days. We're closing it for now. Still, feel free to provide us with requested feedback so that we can reopen it.