ckeditor / ckeditor4

The best enterprise-grade WYSIWYG editor. Fully customizable with countless features and plugins.
https://ckeditor.com/ckeditor-4
Other
5.78k stars 2.46k forks source link

Fix insufficient contrast ratio for links in notifications #5496

Closed Comandeer closed 1 year ago

Comandeer commented 1 year ago

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more on PR testing, how to set the testing environment and how to create tests in the official CKEditor documentation.

This PR contains

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

What is the proposed changelog entry for this pull request?

* [#5495](https://github.com/ckeditor/ckeditor4/issues/5495): Fixed: insufficient color ratio for links inside [notifications](https://ckeditor.com/cke4/addon/notification).

What changes did you make?

I've forced inherited font color for links inside notifications. It seems that the current link color was inherited (pun not intended) from the kama skin.

Additionally, commit 5a4f216eee27653a277b1d97837cad3fd0197b35 contains further (more aggressive) contrast enhancements, involving changing backgrounds of the notifications in the moono and moono-lisa skins (kama has already good contrast ratio).

Which issues does your PR resolve?

Closes #5495.