Migrate to new installation methods

ckeditor / ckeditor5-angular

Official CKEditor 5 Angular 5+ component.

https://ckeditor.com/ckeditor-5

Other

202 stars 110 forks source link

Migrate to new installation methods #419

Closed filipsobol closed 3 months ago

filipsobol commented 3 months ago

Suggested merge commit message (convention)

Feature: Change the implementation to only depend on types from the CKEditor packages and not runtime code to make the integration work with existing and new installation methods.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

filipsobol commented 3 months ago

Upgrading to the latest version of CKEditor (not even to new installation methods) caused two tests to fail.

This issue started with version 41.2.1.

Witoso commented 3 months ago

@niegowski any thoughts? Could it be related to static props?

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build de3cacb5-44dc-4c2d-9cee-33e9ae5d0c90

Details

11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build fb881936-4868-4c35-b179-5170773e4453:	0.0%
Covered Lines:	166
Relevant Lines:	166