Closed f1ames closed 2 months ago
Why did you rewrite the demos to TS?
My worry here: So far, we keep our resources in JS (docs and most other samples I can think of).
8f66b1f is a bit ugly commit but I tried to figure out why the demos don't work
Turned out there were two reasons: dup modules because of WSC and the change in CSS file names that we did recently.
I started pushing here changes that we have to do to make the cke5-demos repo follow changes that were implemented on ckeditor.com.
Why did you rewrite the demos to TS?
My worry here: So far, we keep our resources in JS (docs and most other samples I can think of).
It was a part of this task as we initially discussed with @Witoso and @arkflpc. But I don't know if there is a longer story behind this, maybe they can give more context.
8f66b1f is a bit ugly commit but I tried to figure out why the demos don't work
Turned out there were two reasons: dup modules because of WSC and the change in CSS file names that we did recently.
Yeah, I pushed it before the CSS file names changes, also @pszczesniak pointed that out in the first PR - https://github.com/ckeditor/ckeditor5-demos/pull/38#pullrequestreview-2101619442. I see you already updated it 🙇 👍
I started pushing here changes that we have to do to make the cke5-demos repo follow changes that were implemented on ckeditor.com.
@Reinmar maybe let me know what you are working on here, and how cna I help so we don't duplicate the work.
Ready for review.
The only thing missing is enabling MathType and WProofReader in couple of demos, but this needs to wait for NIM compatible versions of those plugins.
Ready to merge, but I suggest to wait till MathType and WProofReader are bumped to NIM compatible versions?
@f1ames i've tested WProofreader
with alpha version "@webspellchecker/wproofreader-ckeditor5": "3.0.0-alpha.0"
and it works ok.
This PR migrates demos with 3rd-party plugins to NIM. Follow-up of #38:
It's based on
new-installation-methods-v2
branch (#38 PR) and I followed all the same conventions and assumptions. You can read #38 description for all details.The main difference here is that 3rd-party plugins (WProofreader and Mathtype) are commented out in CKEditor 5 plugins list in it's config in each demo. This way demos can be run and after plugins are migrated to NIM, it should be enough to just uncomment those lines.