search

ckeditor / ckeditor5-demos

Source codes for demos available at https://ckeditor.com/ckeditor-5/demo/
42 stars 61 forks source link

Update 3rd-party plugins to NIM compatible versions #42

Closed f1ames closed 2 months ago

f1ames commented 2 months ago

This PR updates MathType and WProofreader to latest versions (NIM compatible).

I also fixed license key message as it mentioned index.ts instead of index.js.

Fixes #41.

Witoso commented 2 months ago

Related to this #43 

In some older snippets, I saw a comment above this plugin with it being commented out. Maybe let's do this?

f1ames commented 2 months ago

Related to this #43 

In some older snippets, I saw a comment above this plugin with it being commented out. Maybe let's do this?

@Witoso You mean to comment out WProofreader plugin by default? Or addin explanation on "blocked" localhost? For commenting out this plugin, it's "WProofreader" so I would assume it should be there, enabled by default 🤔

f1ames commented 2 months ago

Ok, I have added comment to each demo with WProofreader to address #43. Also fixed some demos wich weren't updated before.

@pszczesniak could you take another look if the message makes sense?

f1ames commented 2 months ago

Merging now, since the only requested change is no longer relevant (due to https://github.com/ckeditor/ckeditor5-demos/pull/42#discussion_r1656960506).