search

ckeditor / ckeditor5-package-generator

A tool for creating a new package for CKEditor 5.
Other
6 stars 9 forks source link

Package generator is broken for js option #156

Closed reeveng closed 1 year ago

reeveng commented 1 year ago

šŸ“ Provide detailed reproduction steps (if any)

I tried to generate a package with --js as option, always results in an error after going through several phases.

Steps to reproduce:

  1. run npx ckeditor5-package-generator@latest @somerandomname/ckeditor5-some-random-name --use-yarn
  2. select js as language
  3. wait a bit for the package to start generating
  4. observe this error: image

editorial note:

āœ”ļø Expected result

Not sure, but maybe not an error?

āŒ Actual result

An error that's confusing, did it work, did it not, it generated files, what am I supposed to do with them, yeet them and delete them, or treasure them ...?

ā“ Possible solution

not sure man, haven't looked at the code of the package generator

If you'd like to see this fixed sooner, add a šŸ‘ reaction to this post.

Witoso commented 1 year ago

Thanks for the report! I cannot reproduce it but I'm on MacOS. And it looks like the OP shows Windows. @pomek could your team take a look?

  • also noticed that recently all or nearly all plugins switched to typescript, if javascript plugins are not intended, then remove the option?

This doesn't matter, it determines what will be generated to your src dir, additional files needed, and different webpack configs.

  • it doesn't seem possible to add translated values to custom-plugins?

Not sure what you mean here, please elaborate :)

pomek commented 1 year ago

Something is wrong when a directory contains a space. It can be reproduced on both path styles: Windows and Unix.

image

pomek commented 1 year ago

After removing the following lines, it works as expected.