search

ckeditor / ckeditor5-package-generator

A tool for creating a new package for CKEditor 5.
Other
6 stars 8 forks source link

Default ESLint CKE5 config throws errors #55

Closed Dumluregn closed 2 years ago

Dumluregn commented 3 years ago

📝 Provide a description of the improvement

If you create the package in CKE5 repo (or nested ckeditor5-internal like in my case) and try to create a commit, there is a number of ESLint errors:

  1. Conflicting ESLint configs.
  2. Mismatching devDeps.

Screenshot 2021-10-11 at 13 20 11

I'm not sure if CKE5 devs are exactly the target of this package though.

📃 Other details

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

pomek commented 3 years ago

Is this error about creating invalid package content or reporting an issue with the CKEditor 5 environment? If that latter, it should be reported in CKEditor 5 repository.

Dumluregn commented 3 years ago

These problems happen only after creating the package using the ckeditor5-package-generator, so I don't think it's a problem with CKE5 itself. As I wrote, I just don't know if you intended this package to be used exclusively by the community or by CKE5 devs too. If the latter, then you could adjust the devDeps list to be accepted by the standard CKE5 githooks. If not, you can close this issue.

pomek commented 2 years ago

The tool was created for the community, and I'm sure we didn't think that the CKEditor 5 team would use it to create a new package.

I'll close the issue as it isn't a problem with the tool itself but with the CKEditor 5 development tools in such a case.