No longer duplicate editor when error occurs in `onReady` callback.

ckeditor / ckeditor5-react

Official CKEditor 5 React component.

https://ckeditor.com/ckeditor-5

Other

425 stars 99 forks source link

No longer duplicate editor when error occurs in `onReady` callback. #556

Closed Mati365 closed 1 week ago

Mati365 commented 1 week ago

Suggested merge commit message (convention)

Fix: No longer duplicate editors when error occurs in onReady callback.

Additional information

Throwing exceptions inside onReady might lock semaphore forever, leading to weird artefacts like duplicated elements and too soon watchdog restarts. This PR ensures that onReady is exception free.

Closes https://github.com/cksource/ckeditor5-commercial/issues/6796

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build e96bc15b-dc3c-4d50-ab54-442fa43f53f8

Details

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build a29952f7-4ab2-4d09-a6e5-b1888419d034:	0.0%
Covered Lines:	594
Relevant Lines:	594