search

ckeditor / ckeditor5

Powerful rich text editor framework with a modular architecture, modern integrations, and features like collaborative editing.
https://ckeditor.com/ckeditor-5
Other
9.33k stars 3.68k forks source link

Add CSS variables for code blocks #14149

Open dtdesign opened 1 year ago

dtdesign commented 1 year ago

📝 Provide a description of the improvement

The CSS for code blocks uses static color values for the <pre> element. This makes it a bit more difficult to change the appearance because a different color scheme (such as a dark mode) requires repeating the selector instead of providing a central set of CSS variables.

https://github.com/ckeditor/ckeditor5/blob/37a44d8cb7bae80da150c7b80cfd791cac9a77ce/packages/ckeditor5-code-block/theme/codeblock.css#L8-L10

📃 Other details

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

CKEditorBot commented 3 months ago

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.