search

ckeditor / ckeditor5

Powerful rich text editor framework with a modular architecture, modern integrations, and features like collaborative editing.
https://ckeditor.com/ckeditor-5
Other
9.52k stars 3.7k forks source link

Grammarly deletion suggestion doesn't work on all browsers #14278

Open Witoso opened 1 year ago

Witoso commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Visit the https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html
  2. Make sure Grammarly is enabled.
  3. Write a sentence "I am a a developer".
  4. Try to delete duplicated a.

✔️ Expected result

The word a is deleted.

❌ Actual result

The word a is not removed.

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

mmotyczynska commented 1 year ago

The only event fired by Grammarly in this case (deletion suggestion) is keydown. This is not enough to handle it properly in CKEditor. We would expect beforeinput. As Grammarly has integration with CKEditor 5, we could ask them to improve it for browser extensions by firing additional event.

mmotyczynska commented 1 year ago

BTW, the integration using grammarly-editor-plugin web component works well, so what we'd expect is to modify browser extensions so they work similarly to Grammarly Text Editor SDK.

Witoso commented 1 year ago

The error message suggests this is an upstream problem with the Grammarly extension.

As there's an error for a specific integration, we should reach out to them.

@blacktaxi, as you participated in #267, could you pass the message, or let us know what's the best contact method for such issue?

Witoso commented 1 year ago

Hmm, it magically started working? 😀 Testing Chrome on Mac, and it deletes the example that didn't work before...

https://github.com/ckeditor/ckeditor5/assets/9881379/c5c8a520-2aa3-44df-992e-0bf3331038b7

@mmotyczynska could you check? The Firefox though still works bad for replacement (rel: #14259)

https://github.com/ckeditor/ckeditor5/assets/9881379/7e14e3d2-d9d5-444e-8306-328da7785f8b

mmotyczynska commented 1 year ago

@Witoso Unfortunately, it still doesn't work. The case you've just tested is not about deletion, but changing the verb form. The original one was in the first image caption, not the second (for some reason Grammarly does not mark it anymore). Anyway, a simple sentence I use to test deletion is "I am a a developer" where one "a" should be deleted.

Witoso commented 1 year ago

Yep, there are two different videos, and fixing the first caption works (I think because it's an improvement), but I confirm that the "I am a a developer" doesn't.

Witoso commented 1 year ago

I created a support request: #6307989.

Witoso commented 1 year ago

Posting the first reply for transparency.

Unfortunately, we don’t currently have a quick fix, but we have logged the issue and notified our product team. I can’t provide you with an estimated timeframe right now because the developers need some time to analyze the cause of the issue.
 
In the meantime, we recommend that you use Grammarly for Mac, which integrates with multiple applications and websites. This app appears as a floating widget when you start typing and a Grammarly icon in the menu bar located at the top of your screen.

I've just sent them a follow-up ping.

godai78 commented 9 months ago

On a side note: Grammarly suggestion replacements can pretty badly trash reddit edit area, too. So that might be a larger problem.