Open FilipTokarski opened 1 year ago
@FilipTokarski could you check how it behaves on MacOS?
macOs Chrome:
macOs Firefox:
Composition finishes properly. However, the first part has a bit different characters.
Wanted to add two additional key sequences that we've heard cause issues with CKEditor + Windows to provide more reproduction steps.
awmh
should produce αα±α¬α·
taumifh
should produce α‘αα±α¬αα·αΊ
@FilipTokarski could you check the behavior of those short sequences on Windows again?
Chceked on latest (41.0.0
) docs and I'm not able to reproduce the error.
@FilipTokarski does it result in the exact values?
- Typing
awmh
should produceαα±α¬α·
- Typing
taumifh
should produceα‘αα±α¬αα·αΊ
Yes, those were working ok for me as well.
Based on the above @slotterbackW any chance you could organize tests with your power users on the testing of native Windows IME? It's much easier to debug this one for us than the KeyMagic one.
Yep I asked them yesterday! They came back and said
Firstly we attempted to enter α α±α by typing ap>. It worked perfectly. We then tried to enter αα«α α±α by typing ygap>, and we managed to reproduce the issue. We could see that after typing ygap, the blinking cursor disappeared as CKEditor had lost focus. At this point of time, typing > resulted nothing to the editor. When I pressed the space bar, the scrollbar immediately jumped to the end of the page. I had to click into the editor again to resume typing. I could see that the underline did not go away after typing >
Just restating, sounds like typing ygap
using the Myanmar (Visual Order)
keyboard on Windows caused the editor to lose focus once the p
was typed. This was after typing another set of characters so not sure if that's a factor or not.
typing ygap using the Myanmar (Visual Order) keyboard on Windows caused the editor to lose focus once the p was typed
Yes, I can reproduce this behaviour. It manifests in two ways:
ygap
in the empty editor or what you type is the last line in the editor - the editor wil lose focus ygap
between content/paragraphs - selection will jump to the next lineOh, actually if you type ygap
in the empty editor and then when you focus the editor again (just click in the editing area), you get the error that was reported in the initial message:
Uncaught CKEditorError: model-nodelist-offset-out-of-bounds
So unfortunately it's still there.
We were researching this issue. The problem is that for this language, the browser is not firing the compositionend
event after typing ygap
, instead it moves the selection forward, in most cases by 2 characters. If the typed phrase is at the end of the editor, then the selection jumps to the nearest text node after the editor. While typing inside some text, the selection jumps 2 characters forward. The same behavior can be reproduced in the plain content-editable element so this is a browser bug.
Since the compositionend
event was not fired, the model is not updated and there is a misalignment between the DOM and model/view, and position mapping fails (the reported model-nodelist-offset-out-of-bounds
error).
While debugging it we were looking for a workaround. This is a tricky case because without the compositionend
event, we do not have the data to insert into the model (we do not use beforeinput
insertCompositionText
on desktop). We could try to monitor the document selection and try to "break" the composition if detected selection outside the composed range, but this is tricky since the composition does not provide API to stop it.
Since the above happens only in Chrome on Windows I'd like to check if implementing the EditContext
could help resolving this issue.
@niegowski can we report this issue to the Chromium with the reproduction steps?
@niegowski can we report this issue to the Chromium with the reproduction steps?
Reported to Chromium: https://issues.chromium.org/issues/344767735
@slotterbackW we will push it through Chromium support, it's possible that this also affects this KeyMagic bug (#14117), but I'm not sure. It's weird that both are related to Chrome + Windows.
π Provide detailed reproduction steps (if any)
Myanmar (Visual Order)
tm;vHk;yJ tqifayjujygap>
βοΈ Expected result
You are able to type the full sequence. Text composes properly-
α‘α¬αΈαα―αΆαΈαα² α‘αααΊβααΌα±ααΌαα«α α±α
β Actual result
Not able to finish typing, composition stops just before few last characters. If you then put cursor after this text and start typing, errors are thrown:
β Possible solution
If you have ideas, you can list them here. Otherwise, you can delete this section.
π Other details
If you'd like to see this fixed sooner, add a π reaction to this post.