search

ckeditor / ckeditor5

Powerful rich text editor framework with a modular architecture, modern integrations, and features like collaborative editing.
https://ckeditor.com/ckeditor-5
Other
9.35k stars 3.68k forks source link

After pasting a table from Excel, the text that should appear below it is instead positioned to the right of the table #14716

Open charlttsie opened 1 year ago

charlttsie commented 1 year ago

📝 Provide detailed reproduction steps (if any)

  1. Open a manual test that has the Paste from Office plugin included, e.g. http://localhost:8125/ckeditor5-paste-from-office/tests/manual/integration.html
  2. Copy a table from Excel
  3. Paste the table above some text

✔️ Expected result

The text is placed below the table:

expected-table-text

❌ Actual result

The table and the text are in the same line:

table-text

https://github.com/ckeditor/ckeditor5/assets/132071257/ec435950-fc84-4223-a8ce-e8f0782ccb04

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

mlewand commented 1 year ago

This is a change of behavior introduced in 39.0.0 in #14564

mlewand commented 1 year ago

This could be tricky as aligned tables indeed don't have overflowing text by default.

I wonder whether we could use a different approach to side-align table. For example, if we used margin-left: 0; margin-right: auto; (could be extracted to content style class for readability) instead of float: left to denote left aligned table it would behave the same way as in MS Word.

CKEditorBot commented 1 month ago

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.