search

ckeditor / ckeditor5

Powerful rich text editor framework with a modular architecture, modern integrations, and features like collaborative editing.
https://ckeditor.com/ckeditor-5
Other
9.59k stars 3.7k forks source link

CKEditor 5 + Grammar and Spelling checker by Ginger - all text in the editor is deleted #15219

Open igrebenjuktmp opened 1 year ago

igrebenjuktmp commented 1 year ago

Unstable behaviour while using the Grammar and Spelling checker by Ginger extension in the Chrome browser.

If you select some text and then deselect it, then all text in the editor is deleted. You can check it in demo:

Browser: Google Chrome. Version 118.0.5993.89 (Official Build) (64-bit) OS: Windows 10

Witoso commented 1 year ago

Could you record and share a video? I cannot reproduce it.

igrebenjuktmp commented 1 year ago

I made a mistake with the name of the extension, the problem is with Grammar and Spelling checker by Ginger Here's a video https://www.vidline.com/share/V02WH2OLY2/11915835f85d995d28dbc97171bf47ee

Note that CKEditor 4 works fine with this extension

Witoso commented 1 year ago

It would be great to report this to Ginger as well. It's highly probable they need to change the implementation on their side to handle properly the events of CKEditor 5.

igrebenjuktmp commented 1 year ago

Could you please clarify what is the issue with the Ginger extension might be. Or maybe you have any suggestions for Ginger in this case. I'm wondering what could change in CKEditor5, considering that CKEditor4 works fine with this extension.

Witoso commented 1 year ago

CKEditor 5 is an entirely different editor than CKE4, written from scratch, with a new data model layer and engine. Our typing is based on the beforeInput event, and this may be the root of the issue.

I strongly believe it is up to the integration and extension to ensure it works correctly, then for us to provide some workarounds. Unless, of course, some issue is, in fact, on our side.

igrebenjuktmp commented 1 year ago

Are there any possible workarounds in this case similar to the Grammarly extension issues (e.g. extension may be blocked)?

Witoso commented 1 year ago

The issue you're linking is pretty dated. Grammarly worked on their side to make sure their extension works well with the CKEditor 5. I'm not sure if we will have time right now to block Ginger. If you would rather not report the issue to them, then I can do this, just let me know.

igrebenjuktmp commented 1 year ago

Thanks for the support, I'll report the problem to Ginger and let you know if there are any updates

igrebenjuktmp commented 1 year ago

Unfortunately there is still no feedback from Ginger. Maybe you can find out something from them about this issue

CKEditorBot commented 1 week ago

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.