Closed mremiszewski closed 1 week ago
The recent updates to the CKEditor5 multi-root editor focus on enhancing the user interface by introducing a new MenuBarView
. This addition facilitates better navigation and focus management between the editing areas and the menu bar. Key changes include the implementation of the menu bar, adjustments to UI and testing environments, and improved focus handling mechanisms.
File Path | Changes Summary |
---|---|
.../multirooteditorui.ts |
Added normalizeMenuBarConfig import and _initMenuBar method for menu bar initialization with focus key bindings. |
.../multirooteditoruiview.ts |
Introduced MenuBarView , its instantiation, and configuration based on locale attributes. |
.../tests/manual/multirooteditor.html |
New <div> for the menu bar, updated CSS for layout adjustments. |
.../tests/manual/multirooteditor.js |
Appended menu bar element to the DOM within '.menubar-container'. |
.../tests/multirooteditorui.js |
Enhanced focus handling and navigation between the editing root and the menu bar, including related test cases. |
.../tests/multirooteditoruiview.js |
Added tests for MenuBarView regarding creation, locale, rendering, and CSS attributes; updated destruction and element manipulation tests. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Please use the util for ClassicEditor
as well, AFAICS, the integration is same there as well.
Suggested merge commit message (convention)
Feature (editor-multi-root): Add integration with menu bar.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.
Summary by CodeRabbit
New Features
MenuBarView
in the editor for enhanced navigation and focus handling.Enhancements
Tests
MenuBarView
functionalities, including focus handling and UI integration.