Mention Suggestions goes out of frames.

Anuj-logiciel commented 4 years ago

Steps To reprodude

I am checking this in Mobile device (Safari | iPhone XR) & I also needed to implement this in mobile App (IONIC). Here's steps to reproduce:-

Typing and selecting from suggestions works fine, Also Suggestion box appears correctly.
Now when we try to remove tag (Tag is last word in line), Then if we goes with pressing backspace, suggestion moves to right and goes out of frame.

✔️ Expected result

It Should show as it shows while typing, Only while deleting characters from selected mentined tag is causing the issue.

❌ Actual result

While we are removing characters from selected mention, Suggestion box is going out of frame from right.

📃 Other details

Browser: Safari (Attached images)
OS: iOS
CKEditor version: Checking Demo directly in Browser. I am also facing this in latest version of plugin (Using with React).
Installed CKEditor plugins: Added Mention plugin with classic build of CKEDITOR.

Current Behaviour -

Expected Behaviour -

EDIT -

This issue also occurs when while mentioning, 2 words falls in last and 3 words drops while searching, then Suggestion popup goes from out of frames from left.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

FilipTokarski commented 4 years ago

Hi, thanks for this report. Unfortunately I can confirm this bug happens on Android too ( on manual tests ):

9_mention1

dtdesign commented 1 year ago

This issue still exists to this day and can be reproduced on both iOS and Android. One of our users has provided this video that shows the updated placement of the suggestions when the selection wraps to the next line.

https://github.com/ckeditor/ckeditor5/assets/208610/cb38d61b-3bdd-4d90-b3db-64bedb8646c0

I understand that you might prioritize things differently so if you could at least provide some hints where to look for, I would gladly dig into this.

Witoso commented 1 year ago

@oleq is there a way to dynamically set the dropdown position here to "fix it"?

oleq commented 1 year ago

Sorry, I don't think there's any open API that would allow customization of the mentions panel's position. The team would need to look into this and propose a fix.

CKEditorBot commented 1 month ago

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

ckeditor / ckeditor5