search

ckeditor / ckeditor5

Powerful rich text editor framework with a modular architecture, modern integrations, and features like collaborative editing.
https://ckeditor.com/ckeditor-5
Other
9.55k stars 3.7k forks source link

Update the target ECMAScript version #9240

Closed mlewand closed 1 year ago

mlewand commented 3 years ago

Provide a description of the task

Our ESLint config states that we're using ES2018 (9). This is no longer the case as I can see in the code multiple usage of features that were introduced with ES2019 so that's the version that we should be using.

Some examples:

Also in the docs we say that we're using ES2015:

CKEditor 5 is written in ECMAScript 2015 (also called ES6). (…)

Similar thing in what's new guide.

Reinmar commented 3 years ago

Why do we need to define this at all?

What matters is in which browser the editor works. I'd clean this up whenever possible unless we have specific use cases for these checks.

As for docs, I'd write we use "ES2015+" and that's it.

mlewand commented 3 years ago

Why do we need to define this at all?

I'm fine with dropping this information from our tools whenever possible :+1:

As for docs, I'd write we use "ES2015+" and that's it.

I think we need to upgrade our stack for this. Otherwise that might not be true because of ES2020. It brings optional chaining and nullish coalescing language features.

We use terser v4.6.x and my quick google search says that the support for optional chaining was added only in v5.2.0.

CKEditorBot commented 1 year ago

There has been no activity on this issue for the past two years. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot commented 1 year ago

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).