ckeditor / ckeditor5

Powerful rich text editor framework with a modular architecture, modern integrations, and features like collaborative editing.
https://ckeditor.com/ckeditor-5
Other
9.36k stars 3.68k forks source link

@ckeditor-dev-webpack-plugin and encore 1.2.0 #9652

Closed kl3sk closed 11 months ago

kl3sk commented 3 years ago

📝 Provide detailed reproduction steps (if any)

  1. Update webpack-encore to 1.2.0

✔️ Expected result

Stating of encore and webpack dev server

❌ Actual result

9% setup compilation DefinePlugin/home/<user>/<project>/node_modules/@symfony/webpack-encore/node_modules/webpack/lib/util/MapHelpers.js:17
        const value = map.get(key);
                          ^

TypeError: Cannot read property 'get' of undefined
    at exports.provide (/home/<user>/<project>/node_modules/@symfony/webpack-encore/node_modules/webpack/lib/util/MapHelpers.js:17:20)
    at /home/<user>/<project>/node_modules/@symfony/webpack-encore/node_modules/webpack/lib/DefinePlugin.js:289:51
    at Hook.eval [as call] (eval at create (/home/<user>/<project>/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:392:1)
    at Hook.CALL_DELEGATE [as _call] (/home/<user>/<project>/node_modules/tapable/lib/Hook.js:14:14)
    at Compiler.newCompilation (/home/<user>/<project>/node_modules/webpack/lib/Compiler.js:993:26)
    at /home/<user>/<project>/node_modules/webpack/lib/Compiler.js:1035:29
    at Hook.eval [as callAsync] (eval at create (/home/<user>/<project>/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:22:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/home/<user>/<project>/node_modules/tapable/lib/Hook.js:18:14)
    at Compiler.compile (/home/<user>/<project>/node_modules/webpack/lib/Compiler.js:1030:28)
    at /home/<user>/<project>/node_modules/webpack/lib/Watching.js:132:19

📃 Other details

Encore use Webpack 5.35

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

kl3sk commented 3 years ago

FYI https://github.com/symfony/webpack-encore/issues/972

Reinmar commented 3 years ago

Hi! Can you provide more details on how to reproduce the issue? I'm afraid it's not clear to me, despite the linked thread.

kl3sk commented 3 years ago

I show you the package.json I have, it may help.

    "devDependencies": {
        "@ckeditor/ckeditor5-dev-utils": "^24.4.2",
        "@ckeditor/ckeditor5-dev-webpack-plugin": "^24.4.2",
        "@fortawesome/fontawesome-free": "^5.15.3",
        "@symfony/stimulus-bridge": "^2.1.0",
        "@symfony/ux-dropzone": "file:vendor/symfony/ux-dropzone/Resources/assets",
        "@symfony/webpack-encore": "^1.1.2",
        "@types/cleave.js": "^1.4.4",
        "@types/jest": "^26.0.23",
        "@types/jquery": "^3.5.5",
        "core-js": "^3.12.0",
        "node-sass": "^5.0.0",
        "npm-check-updates": "^11.5.10",
        "postcss-loader": "^5.2.0",
        "raw-loader": "^4.0.2",
        "regenerator-runtime": "^0.13.7",
        "sass-loader": "^11.0.1",
        "stimulus": "^2.0.0",
        "ts-loader": "^9.1.2",
        "typescript": "^4.2.4",
        "webpack-cli": "^4.6.0",
        "webpack-notifier": "^1.13.0"
    },
...
    "dependencies": {
        "@ckeditor/ckeditor5-adapter-ckfinder": "^27.1.0",
        "@ckeditor/ckeditor5-alignment": "^27.1.0",
        "@ckeditor/ckeditor5-autoformat": "^27.1.0",
        "@ckeditor/ckeditor5-basic-styles": "^27.1.0",
        "@ckeditor/ckeditor5-block-quote": "^27.1.0",
        "@ckeditor/ckeditor5-build-classic": "^27.1.0",
        "@ckeditor/ckeditor5-code-block": "^27.1.0",
        "@ckeditor/ckeditor5-core": "^27.1.0",
        "@ckeditor/ckeditor5-easy-image": "^27.1.0",
        "@ckeditor/ckeditor5-editor-classic": "^27.1.0",
        "@ckeditor/ckeditor5-essentials": "^27.1.0",
        "@ckeditor/ckeditor5-heading": "^27.1.0",
        "@ckeditor/ckeditor5-horizontal-line": "^27.1.0",
        "@ckeditor/ckeditor5-image": "^27.1.0",
        "@ckeditor/ckeditor5-link": "^27.1.0",
        "@ckeditor/ckeditor5-list": "^27.1.0",
        "@ckeditor/ckeditor5-mention": "^27.1.0",
        "@ckeditor/ckeditor5-paragraph": "^27.1.0",
        "@ckeditor/ckeditor5-select-all": "^27.1.0",
        "@ckeditor/ckeditor5-theme-lark": "^27.1.0",
        "@fingerprintjs/fingerprintjs": "^3.1.1",
        "@fortawesome/fontawesome-svg-core": "^1.2.35",
        "@fortawesome/free-brands-svg-icons": "^5.15.3",
        "@fortawesome/free-regular-svg-icons": "^5.15.3",
        "@fortawesome/free-solid-svg-icons": "^5.15.3",
        "@fullcalendar/core": "^5.6.0",
        "@fullcalendar/daygrid": "^5.6.0",
        "@fullcalendar/interaction": "^5.6.0",
        "@fullcalendar/timegrid": "^5.6.0",
        "@tarekraafat/autocomplete.js": "^9.1.1",
        "axios": "^0.21.1",
        "bazinga-translator": "^4.0.1",
        "bootstrap": "^4.6.0",
        "chart.js": "^3.2.1",
        "choices.js": "^9.0.1",
        "cleave.js": "^1.6.0",
        "delegated-events": "^1.1.2",
        "file-loader": "^6.2.0",
        "flatpickr": "^4.6.9",
        "flot": "^4.2.2",
        "imask": "^6.0.7",
        "intl-messageformat": "^9.6.12",
        "jquery": "^3.6.0",
        "js-cookie": "^2.2.1",
        "jspdf": "^2.3.1",
        "jspdf-autotable": "^3.5.14",
        "litepicker": "^2.0.11",
        "noty": "^3.2.0-beta",
        "perfect-scrollbar": "^1.5.1",
        "pickerjs": "^1.2.1",
        "popper.js": "^1.16.1-lts",
        "select2": "^4.0.13",
        "set-value": "^4.0.0",
        "sortablejs": "^1.13.0",
        "sticky-js": "^1.3.0",
        "sweetalert2": "^10.16.7"
    }

What I understand, is Encore require "webpack": "^5.35", and @ckeditor/ckeditor5-dev-webpack-plugin require "webpack": "^4.43.0 || ^5.24.0"

kl3sk commented 3 years ago

@Reinmar, is it enough for you ?

CKEditorBot commented 1 year ago

There has been no activity on this issue for the past two years. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot commented 11 months ago

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).