ckeditor / editor-recommendations

A set of recommendations for modern editing solutions.
https://ckeditor.github.io/editor-recommendations/
47 stars 12 forks source link

Strikethrough #3

Closed Comandeer closed 7 years ago

Comandeer commented 8 years ago

That feature is probably also neccessary, as it's the easiest way to mark something as not longer appropiate or had been deleted.

Therefore we should consider two elements for that:

CKE4 is using s or strike elements for it as a part of basicstyles plugin.

fredck commented 8 years ago

In my personal opinion, s is the one and only way to go.

Comandeer commented 8 years ago

s is more generic, so it can be "abused" to use cases where del is more appropiate (as document edits are also the parts of content that are not longer relevant), so I also think that it's better choice here. del is too "formal" for generic feature (datetimes, sources of edit…) - it's intended to be uses in documents such as HTML5 spec.

Comandeer commented 8 years ago

Some stats. I've checked 22 editors to see how they implement some basic features.

"Strike" is absent in 9 editors, the rest implements it as follows:

Comandeer commented 8 years ago

Actually the name of that feature is "strikethrough", not "strike". I've changed it.

Comandeer commented 8 years ago

I created the first version of draft for that feature: http://ckeditor.github.io/editor-recommendations/features/strikethrough.html Feel free to comment or even prepare some PR to improve it!

Comandeer commented 7 years ago

Ok, it seems like a stable feature. I propose moving it from draft to the recommendation status. I'll wait 3 days for objections and then do what should be done ;)