search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
378 stars 63 forks source link

The editor is not compatible with custom stylesheets #122

Open jodator opened 4 years ago

jodator commented 4 years ago

Compare the below images. The editing window displays differently than the markdown preview.

  1. RTE

Selection_189

  1. Github Markdown preview

Selection_191

This is not a big deal but I'm using custom stylesheet for Github using Stylus plugin and this is how GitHub RTE is displayed for me:

Selection_192

And this is what I would like to see (the code block was changed to JS using markdown):

Selection_193

jodator commented 4 years ago

Side note: it is not whether the content styles are nicer in GitHub RTE but that they differ from the source (GitHub).

fredck commented 4 years ago

We have two issues reported here, in fact:

  1. The code block background doesn't match GH.
  2. The editor is not compatible with custom stylesheets / Stylus.
f1ames commented 4 years ago

For me it's also kind of an issue, I noticed I tend to use Preview often when writing stuff to see and make sure how and if it looks good. Which means that styles inside RTE are slightly different then in the final content (to the extend that it makes you check if it looks fine with Preview).

Probably that's also an old habit from working with markdown (where Preview is really different :smile:), but still inconvenient. And you need two clicks to get to preview - if we would like to get rid of Markdown/Preview as mentioned in #42, the styling should be as similar as possible.

fredck commented 4 years ago

Which means that styles inside RTE are slightly different then in the final content

@f1ames, I'll make an extensive comparison between both, but other than the code block background, which other things you have to point out? 

Actually, would you mind opening an issue for it, pointing out your findings?

I'm wondering if this is not OS specific, because on my mac it looks pretty much the same.

fredck commented 4 years ago

As the code block styles have been recently fixed with #138, I'm leaving this one open for the custom stylesheet issue.

f1ames commented 4 years ago

@f1ames, I'll make an extensive comparison between both, but other than the code block background, which other things you have to point out?

@fredck After using it for longer time I suppose my main issue is the small editable area which makes me always check the final result with a preview (so #20 and #128 related). And missing emoji rendering (which is already fixed in #126 :tada:).

fredck commented 4 years ago

I suppose my main issue is the small editable area which makes me always check the final result with a preview (so #20 and #128 related)

@f1ames ok, thanks for the feedback ;)

CKEditorBot commented 1 year ago

There has been no activity in this issue for the last three years. Now it is marked as stale and will be closed in 30 days. We know it may be valid, so if you're interested in the solution, leave a comment or reaction.

CKEditorBot commented 1 year ago

We have closed the issue because of the lack of activity for the last three years. We know it might be valid, so you can open a similar issue if needed.