search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
378 stars 62 forks source link

Improve the contrast of active buttons #123

Open mlewand opened 4 years ago

mlewand commented 4 years ago

Active bold state is expressed through a different fill color for a relevant button in the editor toolbar.

It's a dark grey vs dark blueish. However I find the contrast between the two to be too little. For me it's extremely difficult to understand which state the given button is in.

It might be better if the background of the button changed a little instead.

Reinmar commented 4 years ago

Big :+1:  I have problems with that all the time.

I generally dislike GH's UI. The buttons are ugly and the styling makes themy inaccessible to me.

As I mentioned on some other occasions – I think we should have CKEditor 5's UI here. Maybe slightly adjusted, but our interface is much better so I'd use it. The quality of our interface is also one of the important traits of CKEditor 5 itself, so losing that here makes no sense to me.

fredck commented 4 years ago

I think we should have CKEditor 5's UI here

One of the premises of GitHub RTE is being as less intrusive as possible. It must feel like magic... you have almost the same UI, but with a full featured rich-text editor.

An idea I have in my mind is introducing a whole new editing experience as an opt-in configuration, using than an "unboxed" editor with the balloon (block?) editor. Anyway, that's for another issue.

When it comes to the issue reported here, the fact is that GH itself doesn't have any state styling on those buttons, so I've opted for the less intrusive option. But ofc, this can be improved with a background style.

CKEditorBot commented 1 year ago

There has been no activity in this issue for the last three years. Now it is marked as stale and will be closed in 30 days. We know it may be valid, so if you're interested in the solution, leave a comment or reaction.

CKEditorBot commented 1 year ago

We have closed the issue because of the lack of activity for the last three years. We know it might be valid, so you can open a similar issue if needed.