Open brenjamesdan opened 4 years ago
One of the initial goals of the project was trying to be as little intrusive as possible when it comes to UI integration within GitHub. Here you have a comparison:
Native GitHub:
GitHub RTE:
As we can see, we have mostly the same UI and features available in the toolbar.
The reason for that was giving a wow effect for GitHub users. They'll feel that they're in the same old editor but (magic!) rich text editing will be enabled in it now.
Additionally, I didn't want to play the "I know better" role. I trust that GitHub has enough resources to manage an awesome UI team that is much probably making informed decision.
But ofc, with an RTE editor, usability changes, so some things could be certainly reviewed. I've just played the safe side, for now.
From the above we can see that GH doesn't provide a strikethrough button at all. Many users may not even know that such feature is available (markdown supports it). So, we're actually doing an important step forward to give them additional stuff in our kebab button.
There was an open talk about this feature inside the CKEditor team itself: ckeditor/editor-recommendations#4.
Underline seems to be seen as a bad usability feature for web content. That's because underline is commonly used to mark links.
GitHub doesn't even mention underline in its markdown documentation (unlike strikethrough), which should say a lot about how unwanted this feature is.
I'm leaving this issue open in any case for discussion so others may jump in with their opinion on the topic.
There has been no activity in this issue for the last three years. Now it is marked as stale and will be closed in 30 days. We know it may be valid, so if you're interested in the solution, leave a comment or reaction.
We have closed the issue because of the lack of activity for the last three years. We know it might be valid, so you can open a similar issue if needed.
The strikethrough is relegated to the secondary menu here. So many other pieces of text0editing software do this same thing! Why does the strikethrough feature almost never appear with the typical bold/italics/underline buttons in these types of software?
Come to think of it, where is the underline button?