search

ckeditor / github-writer

GitHub Writer - WYSIWYG Rich-Text Editor for GitHub, powered by CKEditor.
https://ckeditor.com/
Other
380 stars 62 forks source link

Document incompatibilities with Refined GitHub #251

Open mlewand opened 3 years ago

mlewand commented 3 years ago

There's this fancy extension called Refined GitHub I noticed it tends to cause crashes in GH Writer.

For example, there's a simple repro case:

  1. Install Refined GH extension in addition to GH Writer.
  2. Open some GH repo.
  3. Start creating a new issue (make sure that it uses GH Writer).
  4. Open JS console.
  5. Paste a link, .e.g. https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-basic-styles/src/bold.js

An exception is thrown and editor crashes. It happens due to the fact that Refined GH attempts to make a fancier link by default.

To mitigate it one should go to Refined GH settings and disable shorten-links feature.

fredck commented 3 years ago

Did you have a chance to report it to Refined GitHub as well? They should probably not interfere when pasting into anything which is not the original GH textarea.